pgsql: Use min/max bounds defined by Zstd for compression level - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Use min/max bounds defined by Zstd for compression level
Date
Msg-id E1obJzx-001Uck-9I@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use min/max bounds defined by Zstd for compression level

The bounds hardcoded in compression.c since ffd5365 (minimum at 1 and
maximum at 22) do not match the reality of what zstd is able to
handle, these values being available via ZSTD_maxCLevel() and
ZSTD_minCLevel() at run-time.  The maximum of 22 is actually correct
in recent versions, but the minimum was not as the library can go down
to -131720 by design.  This commit changes the code to use the run-time
values in the code instead of some hardcoded ones.

Zstd seems to assume that these bounds could change in the future, and
Postgres will be able to adapt automatically to such changes thanks to
what's being done in this commit.

Reported-by: Justin Prysby
Discussion: https://postgr.es/m/20220922033716.GL31833@telsasoft.com
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ade925e1693a595ef1c278583fa699ca6fc1ff45

Modified Files
--------------
doc/src/sgml/protocol.sgml | 6 ++++--
src/common/compression.c   | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Etsuro Fujita
Date:
Subject: pgsql: Fix thinko in comment.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Restore archive_command documentation