pgsql: Remove HAVE_UNIX_SOCKETS. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Remove HAVE_UNIX_SOCKETS.
Date
Msg-id E1oMy6b-000dtV-DH@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove HAVE_UNIX_SOCKETS.

Since HAVE_UNIX_SOCKETS is now defined unconditionally, remove the macro
and drop a small amount of dead code.

The last known systems not to have them (as far as I know at least) were
QNX, which we de-supported years ago, and Windows, which now has them.

If a new OS ever shows up with the POSIX sockets API but without working
AF_UNIX, it'll presumably still be able to compile the code, and fail at
runtime with an unsupported address family error.  We might want to
consider adding a HINT that you should turn off the option to use it if
your network stack doesn't support it at that point, but it doesn't seem
worth making the relevant code conditional at compile time.

Also adjust a couple of places in the docs and comments that referred to
builds without Unix-domain sockets, since there aren't any.  Windows
still gets a special mention in those places, though, because we don't
try to use them by default there yet.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/CA%2BhUKG%2BL_3brvh%3D8e0BW_VfX9h7MtwgN%3DnFHP5o7X2oZucY9dg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f5580882856963d1b50f9e391a8dda82d44b69a6

Modified Files
--------------
doc/src/sgml/libpq.sgml             |  9 ++++----
doc/src/sgml/ref/psql-ref.sgml      |  2 +-
src/backend/libpq/hba.c             | 10 ---------
src/backend/libpq/pqcomm.c          | 18 ----------------
src/backend/postmaster/postmaster.c |  2 --
src/backend/utils/misc/guc.c        |  4 ----
src/bin/initdb/initdb.c             | 41 -------------------------------------
src/bin/pg_upgrade/option.c         |  4 ++--
src/bin/pg_upgrade/server.c         |  2 +-
src/common/ip.c                     | 11 ----------
src/include/port.h                  |  3 ---
src/interfaces/libpq/fe-connect.c   | 12 -----------
src/test/regress/pg_regress.c       | 24 ++++------------------
13 files changed, 12 insertions(+), 130 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid misbehavior when hash_table_bytes < bucket_size.