pgsql: Simplify gettimeofday for Windows. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Simplify gettimeofday for Windows.
Date
Msg-id E1oKUHC-000eFz-Um@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Simplify gettimeofday for Windows.

Previously we bothered to forward-declare struct timezone, following man
pages on typical systems, but POSIX actually says the argument (which we
ignore anyway) is void *.  Drop a line.

While here, add an assertion that nobody actually uses the tzp argument.

Previously we did extra work to select between Windows APIs needed on
older releases, but now we can just use the higher resolution function
directly.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CA%2BhUKGKwRpvGfcfq2qNVAQS2Wg1B9eA9QRhAmVSyJt1zsCN2sQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/24c3ce8f1c707f9eeb1f68cebd44c2516ff799c2

Modified Files
--------------
src/include/port/win32_port.h |  5 ++--
src/port/win32gettimeofday.c  | 67 ++++++++-----------------------------------
2 files changed, 14 insertions(+), 58 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
Next
From: Thomas Munro
Date:
Subject: pgsql: Simplify replacement code for strtof.