pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
Date
Msg-id E1o1Mic-0008RL-Bz@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Re-add locally-generated files in pg_upgrade's .gitignore and Makefile

This reverts the changes to pg_upgrade's Makefile and .gitignore done in
15b6d21.  The TAP tests run in isolation, executing pg_upgrade in
tmp_check/ in the build directory so as any files created in the
execution path (reindex_hash.sql and delete_old_cluster.{sh,bat}) are
never in the tree, so entries are not necessary in this case.  However,
not having these impacts the cleanliness of the code tree when running
./pg_upgrade directly from src/bin/pg_upgrade/.

This commit adds back to .gitignore all the files generated in the
execution path, and the Makefile rule to clean them up if they exist.

Per gripe from Tom Lane.

Discussion: https://postgr.es/m/90595.1655227384@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a059e15cdeef3e8de9a34de48c49c29d398bf4e8

Modified Files
--------------
src/bin/pg_upgrade/.gitignore | 4 ++++
src/bin/pg_upgrade/Makefile   | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix cache look-up failures while applying changes in logical rep
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Link to MVCC docs in MERGE docs