pgsql: Avoid ecpglib core dump with out-of-order operations. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid ecpglib core dump with out-of-order operations.
Date
Msg-id E1o1EqX-0004yK-4A@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid ecpglib core dump with out-of-order operations.

If an application executed operations like EXEC SQL PREPARE
without having first established a database connection, it could
get a core dump instead of the expected clean failure.  This
occurred because we did "pthread_getspecific(actual_connection_key)"
without ever having initialized the TSD key actual_connection_key.
The results of that are probably platform-specific, but at least
on Linux it often leads to a crash.

To fix, add calls to ecpg_pthreads_init() in the code paths that
might use actual_connection_key uninitialized.  It's harmless
(and hopefully inexpensive) to do that more than once.

Per bug #17514 from Okano Naoki.  The problem's ancient, so
back-patch to all supported branches.

Discussion: https://postgr.es/m/17514-edd4fad547c5692c@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f7797747fc8fa6e5d5513e6871ee56f7cf91c51c

Modified Files
--------------
src/interfaces/ecpg/ecpglib/connect.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: clarify the default collation behavior of domains.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test