pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.
Date
Msg-id E1noYYm-0004TQ-74@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
configure: don't probe for libldap_r if libldap is 2.5 or newer.

In OpenLDAP 2.5 and later, libldap itself is always thread-safe and
there's never a libldap_r.  Our existing coding dealt with that
by assuming it wouldn't find libldap_r if libldap is thread-safe.
But that rule fails to cope if there are multiple OpenLDAP versions
visible, as is likely to be the case on macOS in particular.  We'd
end up using shiny new libldap in the backend and a hoary libldap_r
in libpq.

Instead, once we've found libldap, check if it's >= 2.5 (by
probing for a function introduced then) and don't bother looking
for libldap_r if so.  While one can imagine library setups that
this'd still give the wrong answer for, they seem unlikely to
occur in practice.

Per report from Peter Eisentraut.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/fedacd7c-2a38-25c9-e7ff-dea549d0e979@enterprisedb.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/af9b967671533965debc9caf3e20fd65a3c71ae4

Modified Files
--------------
configure    | 13 ++++++++++++-
configure.in |  9 ++++++++-
2 files changed, 20 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: noreply@postgresql.org
Date:
Subject: pgsql: Tag refs/tags/REL_14_3 was created
Next
From: David Rowley
Date:
Subject: pgsql: Fix some incorrect preprocessor tests in tuplesort specializatio