pgsql: Revert recent changes with durable_rename_excl() - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Revert recent changes with durable_rename_excl()
Date
Msg-id E1njvSU-001UEu-7u@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert recent changes with durable_rename_excl()

This reverts commits 2c902bb and ccfbd92.  Per buildfarm members
kestrel, rorqual and calliphoridae, the assertions checking that a TLI
history file should not exist when created by a WAL receiver have been
failing, and switching to durable_rename() over durable_rename_excl()
would cause the newest TLI history file to overwrite the existing one.
We need to think harder about such cases, so revert the new logic for
now.

Note that all the failures have been reported in the test
025_stuck_on_old_timeline.

Discussion: https://postgr.es/m/511362.1651116498@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55b56865115eccd6449e79d6f06fe49d6ba3b792

Modified Files
--------------
contrib/basic_archive/basic_archive.c |  5 ++-
src/backend/access/transam/timeline.c | 18 ++++++----
src/backend/access/transam/xlog.c     | 10 +++---
src/backend/storage/file/fd.c         | 63 +++++++++++++++++++++++++++++++++++
src/include/pg_config_manual.h        |  7 ++++
src/include/storage/fd.h              |  1 +
6 files changed, 91 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename
Next
From: Etsuro Fujita
Date:
Subject: pgsql: Disable asynchronous execution if using gating Result nodes.