pgAdmin 4 commit: Fixed the following issues for the new query tool: - Mailing list pgadmin-hackers

From Akshay Joshi
Subject pgAdmin 4 commit: Fixed the following issues for the new query tool:
Date
Msg-id E1njIup-0006ry-14@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Fixed the following issues for the new query tool:
 1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes
aremade to always search from the start. 
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0795b22ae6fd63a6d5bd130497d3f8eebf27b5f7
Author: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>

Modified Files
--------------
web/pgadmin/static/js/components/CodeMirror.jsx        | 13 +++++++++----
.../static/js/components/QueryToolComponent.jsx        | 18 +++++++++++-------
.../static/js/components/QueryToolDataGrid/Editors.jsx |  2 +-
.../static/js/components/dialogs/FilterDialog.jsx      |  2 +-
.../static/js/components/sections/MainToolBar.jsx      |  3 ++-
.../sqleditor/static/js/components/sections/Query.jsx  | 17 +++++++++++++----
6 files changed, 37 insertions(+), 18 deletions(-)


pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Updated documentation for the new query tool.
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM6131] Port query tool to React