pgsql: set_deparse_plan: Reuse variable to appease Coverity - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: set_deparse_plan: Reuse variable to appease Coverity
Date
Msg-id E1nh8lA-000GCY-BL@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
set_deparse_plan: Reuse variable to appease Coverity

Coverity complains that dpns->outer_plan is deferenced (to obtain
->targetlist) when possibly NULL.  We can avoid this by using
dpns->outer_tlist instead, which was already obtained a few lines up.

The fact that we end up with
  dpns->inner_tlist = dpns->outer_tlist
is a bit suspicious-looking and maybe worthy of more investigation, but
I'll leave that for another day.

Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/202204191345.qerjy3kxi3eb@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e70813fbc4aaca35ec012d5a426706bd54e4acab

Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Move ModifyTableContext->lockmode to UpdateContext
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix incorrect format placeholders