pgsql: Remove dead code in do_pg_backup_start(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove dead code in do_pg_backup_start().
Date
Msg-id E1ne090-0004Ts-MP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove dead code in do_pg_backup_start().

As of commit 39969e2a1, no caller of do_pg_backup_start() passes NULL
for labelfile or tblspcmapfile, nor is it plausible that any would
do so in the future.  Remove the code that coped with that case,
as (a) it's dead and (b) it causes Coverity to bleat about possibly
leaked storage.

While here, do some janitorial work on the function's header comment.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9de692c10176e2af00dc915b122e07bd6903185c

Modified Files
--------------
src/backend/access/transam/xlog.c | 30 +++++++++++++-----------------
1 file changed, 13 insertions(+), 17 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Tweak the default behavior of psql's \dconfig.
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Remove comment about historic heap vacuuming issue.