pgsql: pgstat: fix small bug in pgstat_drop_relation(). - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: pgstat: fix small bug in pgstat_drop_relation().
Date
Msg-id E1ncLo9-000hD7-1t@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pgstat: fix small bug in pgstat_drop_relation().

Just after committing 5891c7a8ed8, a test running with debug_discard_caches=1
failed locally...

pgstat_drop_relation() neither checked pgstat_should_count_relation() nor
called pgstat_prep_relation_pending(). With debug_discard_caches=1
rel->pgstat_info wasn't set up, leading pg_stat_get_xact_tuples_inserted()
spuriously still returning > 0 while in the transaction dropping the table.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5e07d3d6bdbff998eb68c131ecd10c448b026e47

Modified Files
--------------
src/backend/utils/activity/pgstat_relation.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: pgstat: store statistics in shared memory.
Next
From: John Naylor
Date:
Subject: Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests