pageinspect: Add more sanity checks to prevent out-of-bound reads
A couple of code paths use the special area on the page passed by the
function caller, expecting to find some data in it. However, feeding
an incorrect page can lead to out-of-bound reads when trying to access
the page special area (like a heap page that has no special area,
leading PageGetSpecialPointer() to grab a pointer outside the allocated
page).
The functions used for hash and btree indexes have some protection
already against that, while some other functions using a relation OID
as argument would make sure that the access method involved is correct,
but functions taking in input a raw page without knowing the relation
the page is attached to would run into problems.
This commit improves the set of checks used in the code paths of BRIN,
btree (including one check if a leaf page is found with a non-zero
level), GIN and GiST to verify that the page given in input has a
special area size that fits with each access method, which is done
though PageGetSpecialSize(), becore calling PageGetSpecialPointer().
The scope of the checks done is limited to work with pages that one
would pass after getting a block with get_raw_page(), as it is possible
to craft byteas that could bypass existing code paths. Having too many
checks would also impact the usability of pageinspect, as the existing
code is very useful to look at the content details in a corrupted page,
so the focus is really to avoid out-of-bound reads as this is never a
good thing even with functions whose execution is limited to
superusers.
The safest approach could be to rework the functions so as these fetch a
block using a relation OID and a block number, but there are also cases
where using a raw page is useful.
Tests are added to cover all the code paths that needed such checks, and
an error message for hash indexes is reworded to fit better with what
this commit adds.
Reported-By: Alexander Lakhin
Author: Julien Rouhaud, Michael Paquier
Discussion: https://postgr.es/m/16527-ef7606186f0610a1@postgresql.org
Discussion: https://postgr.es/m/561e187b-3549-c8d5-03f5-525c14e65bd0@postgrespro.ru
Backpatch-through: 10
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/1a2fdf86aae82e96713a0bfbe7e750d35667d692
Modified Files
--------------
contrib/pageinspect/brinfuncs.c | 18 ++++++++++++++++++
contrib/pageinspect/btreefuncs.c | 14 ++++++++++++++
contrib/pageinspect/expected/brin.out | 10 ++++++++++
contrib/pageinspect/expected/btree.out | 22 ++++++++++++++++++----
contrib/pageinspect/expected/gin.out | 12 ++++++++++--
contrib/pageinspect/expected/hash.out | 14 ++++++++++++--
contrib/pageinspect/ginfuncs.c | 22 +++++++++++++++++++---
contrib/pageinspect/hashfuncs.c | 11 +++++++----
contrib/pageinspect/sql/brin.sql | 8 ++++++++
contrib/pageinspect/sql/btree.sql | 18 ++++++++++++++----
contrib/pageinspect/sql/gin.sql | 9 +++++++--
contrib/pageinspect/sql/hash.sql | 10 ++++++++--
12 files changed, 145 insertions(+), 23 deletions(-)
