pgsql: Fix waiting in RegisterSyncRequest(). - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix waiting in RegisterSyncRequest().
Date
Msg-id E1nUJjT-000GFh-6M@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix waiting in RegisterSyncRequest().

If we run out of space in the checkpointer sync request queue (which is
hopefully rare on real systems, but common with very small buffer pool),
we wait for it to drain.  While waiting, we should report that as a wait
event so that users know what is going on, and also handle postmaster
death, since otherwise the loop might never terminate if the
checkpointer has exited.

Back-patch to 12.  Although the problem exists in earlier releases too,
the code is structured differently before 12 so I haven't gone any
further for now, in the absence of field complaints.

Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cfdb303be756d846031ba1c1d1ff2cae39a62c15

Modified Files
--------------
doc/src/sgml/monitoring.sgml    | 5 +++++
src/backend/postmaster/pgstat.c | 3 +++
src/backend/storage/sync/sync.c | 4 +++-
src/include/pgstat.h            | 3 ++-
4 files changed, 13 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Fix waiting in RegisterSyncRequest().
Next
From: Thomas Munro
Date:
Subject: pgsql: Fix waiting in RegisterSyncRequest().