pgsql: Fix waiting in RegisterSyncRequest(). - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix waiting in RegisterSyncRequest().
Date
Msg-id E1nUJis-000GEQ-Lm@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix waiting in RegisterSyncRequest().

If we run out of space in the checkpointer sync request queue (which is
hopefully rare on real systems, but common with very small buffer pool),
we wait for it to drain.  While waiting, we should report that as a wait
event so that users know what is going on, and also handle postmaster
death, since otherwise the loop might never terminate if the
checkpointer has exited.

Back-patch to 12.  Although the problem exists in earlier releases too,
the code is structured differently before 12 so I haven't gone any
further for now, in the absence of field complaints.

Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3390ef1b7be28eac24dd95af23a4a287e6e7b1a4

Modified Files
--------------
doc/src/sgml/monitoring.sgml            | 5 +++++
src/backend/storage/sync/sync.c         | 4 +++-
src/backend/utils/activity/wait_event.c | 3 +++
src/include/utils/wait_event.h          | 1 +
4 files changed, 12 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: pageinspect: Fix handling of page sizes and AM types
Next
From: Thomas Munro
Date:
Subject: pgsql: Fix waiting in RegisterSyncRequest().