pgsql: Test, don't just Assert, that mergejoin's inputs are in order. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Test, don't just Assert, that mergejoin's inputs are in order.
Date
Msg-id E1nGOPo-0005oO-Kl@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Test, don't just Assert, that mergejoin's inputs are in order.

There are two Asserts in nodeMergejoin.c that are reachable if
the input data is not in the expected order.  This seems way too
fragile.  Alexander Lakhin reported a case where the assertions
could be triggered with misconfigured foreign-table partitions,
and bitter experience with unstable operating system collation
definitions suggests another easy route to hitting them.  Neither
Assert is in a place where we can't afford one more test-and-branch,
so replace 'em with plain test-and-elog logic.

Per bug #17395.  While the reported symptom is relatively recent,
collation changes could happen anytime, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/17395-8c326292078d1a57@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9c7cf083f26e183e200395b3514061bb9d71cc7e

Modified Files
--------------
src/backend/executor/nodeMergejoin.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: First-draft release notes for 14.2.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: be clearer that foreign-table partitions need user-added co