pgsql: Extend the options of pg_basebackup to control compression - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Extend the options of pg_basebackup to control compression
Date
Msg-id E1nAjMX-00016j-1I@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Extend the options of pg_basebackup to control compression

The option --compress is extended to accept a compression method and an
optional compression level, as of the grammar METHOD[:LEVEL].  The
methods currently support are "none" and "gzip", for client-side
compression.  Any of those methods use only an integer value for the
compression level, but any method implemented in the future could use
more specific keywords if necessary.

This commit keeps the logic backward-compatible.  Hence, the following
compatibility rules apply for the new format of the option --compress:
* -z/--gzip is a synonym of --compress=gzip.
* --compress=NUM implies:
** --compress=none if NUM = 0.
** --compress=gzip:NUM if NUM > 0.

Note that there are also plans to extend more this grammar with
server-side compression.

Reviewed-by: Robert Haas, Magnus Hagander, Álvaro Herrera, David
G. Johnston, Georgios Kokolatos
Discussion: https://postgr.es/m/Yb3GEgWwcu4wZDuA@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5c649fe153367cdab278738ee4aebbfd158e0546

Modified Files
--------------
doc/src/sgml/ref/pg_basebackup.sgml          |  21 +++-
src/bin/pg_basebackup/pg_basebackup.c        | 146 +++++++++++++++++++++++----
src/bin/pg_basebackup/t/010_pg_basebackup.pl |  36 ++++++-
3 files changed, 179 insertions(+), 24 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Revert "Make configure prefer python3 to plain python."
Next
From: Thomas Munro
Date:
Subject: pgsql: Add new simple TAP test for tablespaces, attempt II.