pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f - Mailing list pgsql-committers

TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded.  If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6c4a8903b93fa5ee088a282b2e8b79ad6571a853

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)