pgsql: Enable routine running of citext's UTF8-specific test cases. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Enable routine running of citext's UTF8-specific test cases.
Date
Msg-id E1n5B3F-0003IY-23@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Enable routine running of citext's UTF8-specific test cases.

These test cases have been commented out since citext was invented,
because at the time we had no nice way to deal with tests that
have restrictions such as requiring UTF8 encoding.  But now we do
have a convention for that, ie put them into a separate test file
with an early-exit path.  So let's enable these tests to run when
their prerequisites are satisfied.

(We may have to tighten the prerequisites beyond the "encoding = UTF8
and locale != C" checks made here.  But let's put it on the buildfarm
and see what blows up.)

Dag Lem

Discussion: https://postgr.es/m/ygezgoacs4e.fsf_-_@sid.nimrod.no

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c2e8bd27519f47ff56987b30eb34a01969b9a9e8

Modified Files
--------------
contrib/citext/Makefile                   |   2 +-
contrib/citext/expected/citext.out        |  29 ------
contrib/citext/expected/citext_1.out      |  29 ------
contrib/citext/expected/citext_utf8.out   | 146 ++++++++++++++++++++++++++++++
contrib/citext/expected/citext_utf8_1.out |   9 ++
contrib/citext/sql/citext.sql             |  35 -------
contrib/citext/sql/citext_utf8.sql        |  51 +++++++++++
7 files changed, 207 insertions(+), 94 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Reduce relcache access in WAL sender streaming logical changes
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Create foreign key triggers in partitioned tables too