pgsql: Adjust behavior of some env settings for the TAP tests of MSVC - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Adjust behavior of some env settings for the TAP tests of MSVC
Date
Msg-id E1mxJI5-00006V-RK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Adjust behavior of some env settings for the TAP tests of MSVC

edc2332 has introduced in vcregress.pl some control on the environment
variables LZ4, TAR and GZIP_PROGRAM to allow any TAP tests to be able
use those commands.  This makes the settings more consistent with
src/Makefile.global.in, as the same default gets used for Make and MSVC
builds.

Each parameter can be changed in buildenv.pl, but as a default gets
assigned after loading buldenv.pl, it is not possible to unset any of
these, and using an empty value would not work with "||=" either.  As
some environments may not have a compatible command in their PATH (tar
coming from MinGW is an issue, for one), this could break tests without
an exit path to bypass any failing test.  This commit changes things so
as the default values for LZ4, TAR and GZIP_PROGRAM are assigned before
loading buildenv.pl, not after.  This way, we keep the same amount of
compatibility as a GNU build with the same defaults, and it becomes
possible to unset any of those values.

While on it, this adds some documentation about those three variables in
the section dedicated to the TAP tests for MSVC.

Per discussion with Andrew Dunstan.

Discussion: https://postgr.es/m/YbGYe483803il3X7@paquier.xyz
Backpatch-through: 10

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/aadbf825b7c41e241d27dc4d8ed7d77fc4718634

Modified Files
--------------
doc/src/sgml/install-windows.sgml | 34 ++++++++++++++++++++++++++++++++++
src/tools/msvc/vcregress.pl       | 14 +++++++-------
2 files changed, 41 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove pg_upgrade support for upgrading from pre-9.2 servers.
Next
From: Amit Kapila
Date:
Subject: pgsql: Improve parallel vacuum implementation.