pgsql: Default to log_checkpoints=on, log_autovacuum_min_duration=10m - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Default to log_checkpoints=on, log_autovacuum_min_duration=10m
Date
Msg-id E1mwmgR-00043y-Im@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Default to log_checkpoints=on, log_autovacuum_min_duration=10m

The idea here is that when a performance problem is known to have
occurred at a certain point in time, it's a good thing if there is
some information available from the logs to help figure out what
might have happened around that time.

This change attracted an above-average amount of dissent, because
it means that a server with default settings will produce some amount
of log output even if nothing has gone wrong. However, by my count,
the mailing list discussion had about twice as many people in favor
of the change as opposed. The reasons for believing that the extra
log output is not an issue in practice are: (1) the rate at which
messages can be generated by this setting is bounded to one every
few minutes on a properly-configured system and (2) production
systems tend to have a lot more junk in the log from that due to
failed connection attempts, ERROR messages generated by application
activity, and the like.

Bharath Rupireddy, reviewed by Fujii Masao and by me. Many other
people commented on the thread, but as far as I can see that was
discussion of the merits of the change rather than review of the
patch.

Discussion: https://postgr.es/m/CALj2ACX-rW_OeDcp4gqrFUAkf1f50Fnh138dmkd0JkvCNQRKGA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/64da07c41a8c0a680460cdafc79093736332b6cf

Modified Files
--------------
doc/src/sgml/config.sgml                      | 17 ++++++++---------
src/backend/access/transam/xlog.c             |  2 +-
src/backend/postmaster/autovacuum.c           |  2 +-
src/backend/utils/misc/guc.c                  |  4 ++--
src/backend/utils/misc/postgresql.conf.sample |  4 ++--
src/bin/initdb/initdb.c                       |  4 ++--
6 files changed, 16 insertions(+), 17 deletions(-)


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Fix alignment in multirange_get_range() function
Next
From: Robert Haas
Date:
Subject: pgsql: Remove InitXLOGAccess().