pgsql: postgres_fdw: Report warning when timeout expires while getting - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: postgres_fdw: Report warning when timeout expires while getting
Date
Msg-id E1muy0t-000603-Fy@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
postgres_fdw: Report warning when timeout expires while getting query result.

When aborting remote transaction or sending cancel request to a remote server,
postgres_fdw calls pgfdw_get_cleanup_result() to wait for the result of
transaction abort query or cancel request to arrive. It fails to get the result
if the timeout expires or a connection trouble happens.

Previously postgres_fdw reported no warning message even when the timeout
expired or a connection trouble happened in pgfdw_get_cleanup_result().
This could make the troubleshooting harder when such an event occurred.

This commit makes pgfdw_get_cleanup_result() tell its caller what trouble
(timeout or connection error) occurred, on failure, and also makes its caller
report the proper warning message based on that information.

Author: Fujii Masao
Reviewed-by: Bharath Rupireddy
Discussion: https://postgr.es/m/15aa988c-722e-ad3e-c936-4420c5b2bfea@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/815d61fcd485e8c60dba22988bf5a90fc12df32d

Modified Files
--------------
contrib/postgres_fdw/connection.c | 51 ++++++++++++++++++++++++++++++---------
1 file changed, 39 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Allow specifying column list for foreign key ON DELETE SET actio
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Check that we have a working tar before trying to use it