pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP
Date
Msg-id E1mpDXN-0008Lk-4f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Probe $PROVE not $PERL while checking for modules needed by TAP tests.

Normally "prove" and "perl" come from the same Perl installation,
but we support the case where they don't (mainly because the MSys
buildfarm animals need this).  In that case, AX_PROG_PERL_MODULES
is completely the wrong thing to use, because it's checking what
"perl" has.  Instead, make a little TAP test script including the
required modules, and run that under "prove".

We don't need ax_prog_perl_modules.m4 at all after this change,
so remove it.

Back-patch to all supported branches, for the buildfarm's benefit.
(In v10, this also back-patches the effects of commit 264eb03aa.)

Andrew Dunstan and Tom Lane, per an observation by Noah Misch

Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ead5c367d32e08a5779617a6f8adf97082dde557

Modified Files
--------------
aclocal.m4                     |   1 -
config/ax_prog_perl_modules.m4 |  77 -----------------------------
config/check_modules.pl        |  20 ++++++++
configure                      | 108 +++++++----------------------------------
configure.in                   |  26 +++++-----
5 files changed, 53 insertions(+), 179 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Be more specific about OOM in XLogReaderAllocate
Next
From: Tom Lane
Date:
Subject: pgsql: Fix pg_dump --inserts mode for generated columns with dropped co