Avoid crash in rare case of concurrent DROP
When a role being dropped contains is referenced by catalog objects that
are concurrently also being dropped, a crash can result while trying to
construct the string that describes the objects. Suppress that by
ignoring objects whose descriptions are returned as NULL.
The majority of relevant codesites were already cautious about this
already; we had just missed a couple.
This is an old bug, so backpatch all the way back.
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17126-21887f04508cb5c8@postgresql.org
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/02e20bb2dcaa523782a8fe7de1c2ddfefaeff033
Modified Files
--------------
src/backend/catalog/dependency.c | 31 ++++++++++++++++++++-----------
src/backend/catalog/pg_shdepend.c | 6 ++++++
2 files changed, 26 insertions(+), 11 deletions(-)