pgsql: Ensure consistent logical replication of datetime and float8 val - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Ensure consistent logical replication of datetime and float8 val
Date
Msg-id E1mhyWp-00015b-3E@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Ensure consistent logical replication of datetime and float8 values.

In walreceiver, set the publisher's relevant GUCs (datestyle,
intervalstyle, extra_float_digits) to the same values that pg_dump uses,
and for the same reason: we need the output to be read the same way
regardless of the receiver's settings.  Without this, it's possible
for subscribers to misinterpret transmitted values.

Although this is clearly a bug fix, it's not without downsides:
subscribers that are storing values into some other datatype, such as
text, could get different results than before, and perhaps be unhappy
about that.  Given the lack of previous complaints, it seems best
to change this only in HEAD, and to call it out as an incompatible
change in v15.

Japin Li, per report from Sadhuprasad Patro

Discussion: https://postgr.es/m/CAFF0-CF=D7pc6st-3A9f1JnOt0qmc+BcBPVzD6fLYisKyAjkGA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f3d4019da5d026f2c3fe5bd258becf6fbb6b4673

Modified Files
--------------
.../replication/libpqwalreceiver/libpqwalreceiver.c      | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix variable lifespan in ExecInitCoerceToDomain().
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Don't overlook indexes during parallel VACUUM.