pgsql: Replace unicode characters in comments with ascii - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Replace unicode characters in comments with ascii
Date
Msg-id E1mhfHe-0002Ac-KQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Replace unicode characters in comments with ascii

The unicode characters, while in comments and not code, caused MSVC
to emit compiler warning C4819:

  The file contains a character that cannot be represented in the
  current code page (number).  Save the file in Unicode format to
  prevent data loss.

Fix by replacing the characters in print.c with descriptive comments
containing the codepoints and symbol names, and remove the character
in brin_bloom.c which was a footnote reference copied from the paper
citation.

Per report from hamerkop in the buildfarm.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/340E4118-0D0C-4E85-8141-8C40EB22DA3A@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/43a134f28b350c4b731db9dddf2f53c407a7077f

Modified Files
--------------
src/backend/access/brin/brin_bloom.c |   2 +-
src/fe_utils/print.c                 | 110 ++++++++++++++++++++++++++++-------
2 files changed, 91 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Avoid some other O(N^2) hazards in list manipulation.
Next
From: Amit Kapila
Date:
Subject: pgsql: Replace XLOG_INCLUDE_XID flag with a more localized flag.