pgsql: StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportPa - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportPa
Date
Msg-id E1mf1CB-0000FL-3H@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportParameters.

This does a better job grouping related operations together, since
all of the WAL records that we need to write prior to allowing WAL
writes generally and written by a single uninterrupted stretch of code.

Since CleanupAfterArchiveRecovery() just (1) runs recovery_end_command,
(2) removes non-parent xlog files, and (3) archives any final partial
segment, this should be safe, because all of those things are pretty
much unrelated to the WAL record written by XLogReportParameters().

Amul Sul, per a suggestion from me

Discussion: http://postgr.es/m/CAAJ_b97fysj6sRSQEfOHj-y8Jfd5uPqOgO74qast89B4WfD+TA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a75dbf7f9ee6ff0c0e2ab4b224b04fc50c4e6577

Modified Files
--------------
src/backend/access/transam/xlog.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Clarify the logic in a few places in the new balanced merge code
Next
From: Robert Haas
Date:
Subject: pgsql: Remove useless code from CreateReplicationSlot.