pgsql: Fix sscanf limits in pg_dump - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Fix sscanf limits in pg_dump
Date
Msg-id E1mcnAQ-0000Is-RZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix sscanf limits in pg_dump

Make sure that the string parsing is limited by the size of the
destination buffer.

The buffer is bounded by MAXPGPATH, and thus the limit must be
inserted via preprocessor expansion and the buffer increased by
one to account for the terminator. There is no risk of overflow
here, since in this case, the buffer scanned is smaller than the
destination buffer.

Backpatch all the way down to 9.6.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/B14D3D7B-F98C-4E20-9459-C122C67647FB@yesql.se
Backpatch-through: 9.6

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/abdf81a20ba2ddc06a0ebdd58ee8747306fb2004

Modified Files
--------------
src/bin/pg_dump/pg_backup_directory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix bug in TOC file error message printing
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix sscanf limits in pg_dump