pgsql: Fix instability in contrib/bloom TAP tests. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix instability in contrib/bloom TAP tests.
Date
Msg-id E1mVKkV-0007YP-5S@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix instability in contrib/bloom TAP tests.

It turns out that the instability complained of in commit d3c09b9b1
has an embarrassingly simple explanation.  The test script waits for
the standby to flush incoming WAL to disk, but it should wait for
the WAL to be replayed, since we are testing for the effects of that
to be visible.

While at it, use wait_for_catchup instead of reinventing that logic,
and adjust $Test::Builder::Level to improve future error reports.

Back-patch to v12 where the necessary infrastructure came in
(cf. aforesaid commit).  Also back-patch 7d1aa6bf1 so that the
test will actually get run.

Discussion: https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cf26a8d8a75ff4ae78bf0818ebb2bf6cf90db69c

Modified Files
--------------
contrib/bloom/Makefile     | 4 +---
contrib/bloom/t/001_wal.pl | 8 +++-----
2 files changed, 4 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: noreply@postgresql.org
Date:
Subject: pgsql: Tag refs/tags/REL_14_0 was created
Next
From: Michael Paquier
Date:
Subject: pgsql: Refactor output file handling when forking syslogger under EXEC_