pgsql: Fix places in TestLib.pm in need of adaptation to the output of - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix places in TestLib.pm in need of adaptation to the output of
Date
Msg-id E1mSpRd-0007ja-CA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix places in TestLib.pm in need of adaptation to the output of Msys perl

Contrary to the output of native perl, Msys perl generates outputs with
CRLFs characters.  There are already places in the TAP code where CRLFs
(\r\n) are automatically converted to LF (\n) on Msys, but we missed a
couple of places when running commands and using their output for
comparison, that would lead to failures.

This problem has been found thanks to the test added in 5adb067 using
TestLib::command_checks_all(), but after a closer look more code paths
were missing a filter.

This is backpatched all the way down to prevent any surprises if a new
test is introduced in stable branches.

Reviewed-by: Andrew Dunstan, Álvaro Herrera
Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us
Backpatch-through: 9.6

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1b6d1ead3bfbf1771d2cf8fd975f980a16211348

Modified Files
--------------
src/test/perl/TestLib.pm | 4 ++++
1 file changed, 4 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix misevaluation of STABLE parameters in CALL within plpgsql.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs