pgsql: Further portability tweaks for float4/float8 hash functions. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Further portability tweaks for float4/float8 hash functions.
Date
Msg-id E1mMcID-0002ri-Uu@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a5e8f7b3798b6fb9a4f3129a5eab98b7087c8a80

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Minor improvements for psql help output.
Next
From: Michael Paquier
Date:
Subject: pgsql: Remove some unused variables in TAP tests