pgsql: Fix lookup error in extended stats ownership check - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Fix lookup error in extended stats ownership check
Date
Msg-id E1mL6nk-0003S7-CV@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix lookup error in extended stats ownership check

When an ownership check on extended statistics object failed, the code
was calling aclcheck_error_type to report the failure, which is clearly
wrong, resulting in cache lookup errors. Fix by calling aclcheck_error.

This issue exists since the introduction of extended statistics, so
backpatch all the way back to PostgreSQL 10. It went unnoticed because
there were no tests triggering the error, so add one.

Reported-by: Mark Dilger
Backpatch-through: 10, where extended stats were introduced
Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1fe1a04af81de4c659ab2a85e578a6bbd4903035

Modified Files
--------------
src/backend/catalog/objectaddress.c     |  3 ++-
src/test/regress/expected/stats_ext.out | 11 +++++++++++
src/test/regress/sql/stats_ext.sql      |  9 +++++++++
3 files changed, 22 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Fix lookup error in extended stats ownership check
Next
From: Tomas Vondra
Date:
Subject: pgsql: Fix lookup error in extended stats ownership check