pgsql: Fix toast rewrites in logical decoding. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix toast rewrites in logical decoding.
Date
Msg-id E1mIkrO-0006zX-LE@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix toast rewrites in logical decoding.

Commit 325f2ec555 introduced pg_class.relwrite to skip operations on
tables created as part of a heap rewrite during DDL. It links such
transient heaps to the original relation OID via this new field in
pg_class but forgot to do anything about toast tables. So, logical
decoding was not able to skip operations on internally created toast
tables. This leads to an error when we tried to decode the WAL for the
next operation for which it appeared that there is a toast data where
actually it didn't have any toast data.

To fix this, we set pg_class.relwrite for internally created toast tables
as well which allowed skipping operations on them during logical decoding.

Author: Bertrand Drouvot
Reviewed-by: David Zhang, Amit Kapila
Backpatch-through: 11, where it was introduced
Discussion: https://postgr.es/m/b5146fb1-ad9e-7d6e-f980-98ed68744a7c@amazon.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e35705f549f0bb8f0318cd8a08244ba40ba9bdd2

Modified Files
--------------
contrib/test_decoding/expected/toast.out | 22 ++++++++++++++++++++++
contrib/test_decoding/sql/toast.sql      | 16 ++++++++++++++++
src/backend/catalog/toasting.c           | 29 ++++++++++++++++++-----------
src/backend/commands/cluster.c           | 10 +++++++++-
src/backend/commands/tablecmds.c         | 31 +++++++++++++++++++++++++++++++
src/include/catalog/toasting.h           |  2 +-
src/include/commands/tablecmds.h         |  2 ++
7 files changed, 99 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Etsuro Fujita
Date:
Subject: pgsql: Doc: Tweak function prototype indentation for consistency.
Next
From: Fabien COELHO
Date:
Subject: Re: pgsql: psql: Add test for query canceling