pgsql: Remove --quiet option from pg_amcheck - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Remove --quiet option from pg_amcheck
Date
Msg-id E1mH25B-00033j-6G@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove --quiet option from pg_amcheck

Using --quiet in combination with --no-strict-names didn't work as
documented, a warning message was still emitted. Since the --quiet
flag was working in an unconventional way to other utilities, fix
by removing the functionality instead.

Backpatch through 14 where pg_amcheck was introduced.

Bug: 17148
Reported-by: Chen Jiaoqian <chenjq.jy@fujitsu.com>
Reviewed-by: Julien Rouhaud <rjuju123@gmail.com>
Discussion: https://postgr.es/m/17148-b5087318e2b04fc6@postgresql.org
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/92ce7f527960ca672d2ad70e61442f4e5b3bb641

Modified Files
--------------
doc/src/sgml/ref/pg_amcheck.sgml           | 12 ----------
src/bin/pg_amcheck/pg_amcheck.c            | 38 ++++++++++--------------------
src/bin/pg_amcheck/t/002_nonesuch.pl       |  6 ++++-
src/bin/pg_amcheck/t/003_check.pl          |  2 +-
src/bin/pg_amcheck/t/005_opclass_damage.pl |  2 +-
5 files changed, 20 insertions(+), 40 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Remove --quiet option from pg_amcheck
Next
From: Daniel Gustafsson
Date:
Subject: Re: pgsql: psql: Add test for query canceling