pgsql: Improve performance of float overflow checks in btree_gist - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve performance of float overflow checks in btree_gist
Date
Msg-id E1mGX87-00062u-PO@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve performance of float overflow checks in btree_gist

The current code could do unnecessary calls to isinf() (two for the
argument values all the time while one could be sufficient in some
cases).  zero_is_valid was never used but the result value was still
checked on 0 in the first position of the check.

This is similar to 607f8ce.  btree_gist has just copy-pasted the code
doing those checks from the backend float4/8 code, as of the macro
CHECKFLOATVAL(), to do the work.

Author: Haiying Tang
Discussion: https://postgr.es/m/OS0PR01MB611358E3A7BC3C2F874AC36BFBF39@OS0PR01MB6113.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/32cf7f7acce3891cbc3de53327704372bdd36d38

Modified Files
--------------
contrib/btree_gist/btree_float4.c    |  4 +++-
contrib/btree_gist/btree_float8.c    |  8 +++++---
contrib/btree_gist/btree_utils_num.h | 17 -----------------
3 files changed, 8 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Revert refactoring of hex code to src/common/
Next
From: Laurenz Albe
Date:
Subject: Re: pgsql: Allow a multi-row INSERT to specify DEFAULTs for a generated col