pgsql: Make ALTER TRIGGER RENAME consistent for partitioned tables - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Make ALTER TRIGGER RENAME consistent for partitioned tables
Date
Msg-id E1m6hGw-0003Ho-Gw@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Make ALTER TRIGGER RENAME consistent for partitioned tables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Make ALTER TRIGGER RENAME consistent for partitioned tables

Renaming triggers on partitioned tables had two problems: first,
it did not recurse to renaming the triggers on the partitions; and
second, it failed to prohibit renaming clone triggers.  Having triggers
with different names in partitions is pointless, and furthermore pg_dump
would not preserve names for partitions anyway.

Not backpatched -- making the ALTER TRIGGER throw an error in stable
versions might cause problems for existing scripts.

Co-authored-by: Arne Roland <A.Roland@index.de>
Co-authored-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Zhihong Yu <zyu@yugabyte.com>
Discussion: https://postgr.es/m/d0fd7040c2fb4de1a111b9d9ccc456b8@index.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/80ba4bb383538a2ee846fece6a7b8da9518b6866

Modified Files
--------------
doc/src/sgml/ref/alter_trigger.sgml    |  15 ++-
src/backend/commands/trigger.c         | 214 ++++++++++++++++++++++++++-------
src/test/regress/expected/triggers.out |  76 ++++++++++++
src/test/regress/sql/triggers.sql      |  47 ++++++++
4 files changed, 307 insertions(+), 45 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Rework installation instructions again
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Make ALTER TRIGGER RENAME consistent for partitioned tables