pgsql: Don't allow to set replication slot_name as ''. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Don't allow to set replication slot_name as ''.
Date
Msg-id E1m5MTt-0005nq-5N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't allow to set replication slot_name as ''.

We don't allow to create replication slot_name as an empty string ('') via
SQL API pg_create_logical_replication_slot() but it is allowed to be set
via Alter Subscription command. This will lead to apply worker repeatedly
keep trying to stream data via slot_name '' and the user is not allowed to
create the slot with that name.

Author: Japin Li
Reviewed-By: Ranier Vilela, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f2f459f182fc8b1af44e422e2324b7acd5ee2408

Modified Files
--------------
src/backend/commands/subscriptioncmds.c    | 3 +++
src/test/regress/expected/subscription.out | 3 +++
src/test/regress/sql/subscription.sql      | 3 +++
3 files changed, 9 insertions(+)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Adjust commit 2dbe8905 for ancient macOS.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Use l*_node() family of functions where appropriate