pgsql: Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.
Date
Msg-id E1m42rD-0006g1-Aj@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.

Autoconf's AC_CHECK_DECLS() always defines HAVE_DECL_whatever
as 1 or 0, but some of the entries in msvc/Solution.pm showed
such symbols as "undef" instead of 0.  Fix that for consistency.
There's no live bug in current usages AFAICS, but it's not hard
to imagine one creeping in if more-complex #if tests get added.

Back-patch to v13, which is as far back as Solution.pm contains
this data.  The inconsistency still exists in the manually-filled
pg_config_ext.h.win32 files of older branches; but as long as the
problem is only latent, it doesn't seem worth the trouble to
clean things up there.

Discussion: https://postgr.es/m/3185430.1626133592@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/91a1651057b15809058acb174fead131ef8efab8

Modified Files
--------------
src/tools/msvc/Solution.pm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix portability issue with gzip in TAP test of pg_receivewal
Next
From: Tom Lane
Date:
Subject: pgsql: Replace explicit PIN entries in pg_depend with an OID range test