pgsql: Rethink blocking annotations in detach-partition-concurrently-[3 - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Rethink blocking annotations in detach-partition-concurrently-[3
Date
Msg-id E1m0TRQ-0006S9-MD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rethink blocking annotations in detach-partition-concurrently-[34].

In 741d7f104, I tried to make the reports from canceled steps come out
after the pg_cancel_backend() steps, since that was the most common
ordering before.  However, that doesn't ensure that a canceled step
doesn't report even later, as shown in a recent failure on buildfarm
member idiacanthus.  Rather than complicating things even more with
additional annotations, let's just force the cancel's effect to be
reported first.  It's not *that* unnatural-looking.

Back-patch to v14 where these test cases appeared.

Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=idiacanthus&dt=2021-07-02%2001%3A40%3A04

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c04c767059b8460b99f6aa4aae5450ab3ee257a3

Modified Files
--------------
.../expected/detach-partition-concurrently-3.out   | 126 ++++++++++++---------
.../expected/detach-partition-concurrently-4.out   |  56 +++++----
.../specs/detach-partition-concurrently-3.spec     |  40 +++----
.../specs/detach-partition-concurrently-4.spec     |  38 +++----
4 files changed, 143 insertions(+), 117 deletions(-)


pgsql-committers by date:

Previous
From: Dean Rasheed
Date:
Subject: pgsql: Prevent numeric overflows in parallel numeric aggregates.
Next
From: Tom Lane
Date:
Subject: pgsql: Reduce overhead of cache-clobber testing in LookupOpclassInfo().