pgsql: Prevent race condition while reading relmapper file. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Prevent race condition while reading relmapper file.
Date
Msg-id E1lwK4R-0008TI-DF@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent race condition while reading relmapper file.

Contrary to the comment here, POSIX does not guarantee atomicity of a
read(), if another process calls write() concurrently. Or at least Linux
does not. Add locking to load_relmap_file() to avoid the race condition.

Fixes bug #17064. Thanks to Alexander Lakhin for the report and test case.

Backpatch-through: 9.6, all supported versions.
Discussion: https://www.postgresql.org/message-id/17064-bb0d7904ef72add3@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2a0ab13f8dd1346d03b00a737734aeca036514f9

Modified Files
--------------
src/backend/utils/cache/relmapper.c | 34 ++++++++++++++++++++--------------
1 file changed, 20 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Doc: Update logical replication message formats.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Another fix to relmapper race condition.