pgsql: Fix deadlock for multiple replicating truncates of the same tabl - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix deadlock for multiple replicating truncates of the same tabl
Date
Msg-id E1ljvst-00074h-8e@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix deadlock for multiple replicating truncates of the same table.

While applying the truncate change, the logical apply worker acquires
RowExclusiveLock on the relation being truncated. This allowed truncate on
the relation at a time by two apply workers which lead to a deadlock. The
reason was that one of the workers after updating the pg_class tuple tries
to acquire SHARE lock on the relation and started to wait for the second
worker which has acquired RowExclusiveLock on the relation. And when the
second worker tries to update the pg_class tuple, it starts to wait for
the first worker which leads to a deadlock. Fix it by acquiring
AccessExclusiveLock on the relation before applying the truncate change as
we do for normal truncate operation.

Author: Peter Smith, test case by Haiying Tang
Reviewed-by: Dilip Kumar, Amit Kapila
Backpatch-through: 11
Discussion: https://postgr.es/m/CAHut+PsNm43p0jM+idTvWwiGZPcP0hGrHMPK9TOAkc+a4UpUqw@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/18c6242b7c6da78341b6745bc9b0bcbca20d556b

Modified Files
--------------
src/backend/replication/logical/worker.c |  5 +--
src/test/subscription/t/010_truncate.pl  | 53 +++++++++++++++++++++++++++++++-
2 files changed, 55 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Avoid detoasting failure after COMMIT inside a plpgsql FOR loop.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Put some psql documentation pieces back into alphabetical order