Undo decision to allow pg_proc.prosrc to be NULL.
Commit e717a9a18 changed the longstanding rule that prosrc is NOT NULL
because when a SQL-language function is written in SQL-standard style,
we don't currently have anything useful to put there. This seems a poor
decision though, as it could easily have negative impacts on external
PLs (opening them to crashes they didn't use to have, for instance).
SQL-function-related code can just as easily test "is prosqlbody not
null" as "is prosrc null", so there's no real gain there either.
Hence, revert the NOT NULL marking removal and adjust related logic.
For now, we just put an empty string into prosrc for SQL-standard
functions. Maybe we'll have a better idea later, although the
history of things like pg_attrdef.adsrc suggests that it's not
easy to maintain a string equivalent of a node tree.
This also adds an assertion that queryDesc->sourceText != NULL
to standard_ExecutorStart. We'd been silently relying on that
for awhile, so let's make it less silent.
Also fix some overlooked documentation and test cases.
Discussion: https://postgr.es/m/2197698.1617984583@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1111b2668d89bfcb6f502789158b1233ab4217a6
Modified Files
--------------
doc/src/sgml/catalogs.sgml | 16 ++++--
src/backend/catalog/pg_proc.c | 31 +++++-------
src/backend/commands/functioncmds.c | 11 ++++-
src/backend/executor/execMain.c | 2 +
src/backend/executor/functions.c | 20 ++++----
src/backend/optimizer/util/clauses.c | 66 ++++++++++++-------------
src/bin/pg_dump/pg_dump.c | 2 +-
src/bin/psql/describe.c | 2 +-
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.h | 2 +-
src/include/executor/functions.h | 5 +-
src/test/regress/expected/create_function_3.out | 6 +++
src/test/regress/expected/opr_sanity.out | 11 ++++-
src/test/regress/sql/create_function_3.sql | 5 ++
src/test/regress/sql/opr_sanity.sql | 7 ++-
15 files changed, 109 insertions(+), 79 deletions(-)
