pgsql: Improve stability of test with vacuum_truncate in reloptions.sql - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve stability of test with vacuum_truncate in reloptions.sql
Date
Msg-id E1lS7wy-0005iw-04@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve stability of test with vacuum_truncate in reloptions.sql

This test has been using a simple VACUUM with pg_relation_size() to
check if a relation gets physically truncated or not, but forgot the
fact that some concurrent activity, like checkpoint buffer writes, could
cause some pages to be skipped.  The second test enabling
vacuum_truncate could fail, seeing a non-empty relation.  The first test
would not have failed, but could finish by testing a behavior different
than the one aimed for.  Both tests gain a FREEZE option, to make the
vacuums more aggressive and prevent page skips.

This is similar to the issues fixed in c2dc1a7.

Author: Arseny Sher
Reviewed-by: Masahiko Sawada
Discussion: https://postgr.es/m/87tuotr2hh.fsf@ars-thinkpad
backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe246d1c111d43fd60a1b0afff25ed09b7ae11eb

Modified Files
--------------
src/test/regress/expected/reloptions.out | 6 ++++--
src/test/regress/sql/reloptions.sql      | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Rethink handling of pass-by-value leaf datums in SP-GiST.
Next
From: David Rowley
Date:
Subject: pgsql: Add Result Cache executor node (take 2)