pgsql: Use valid compression method in brin_form_tuple - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Use valid compression method in brin_form_tuple
Date
Msg-id E1lNl1x-0007Gq-Er@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use valid compression method in brin_form_tuple

When compressing the BRIN summary, we can't simply use the compression
method from the indexed attribute.  The summary may use a different data
type, e.g. fixed-length attribute may have varlena summary, leading to
compression failures.  For the built-in BRIN opclasses this happens to
work, because the summary uses the same data type as the attribute.

When the data types match, we can inherit use the compression method
specified for the attribute (it's copied into the index descriptor).
Otherwise we don't have much choice and have to use the default one.

Author: Tomas Vondra
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Discussion: https://postgr.es/m/e0367f27-392c-321a-7411-a58e1a7e4817%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/882b2cdc08c4100e273f24742e2118be98708a07

Modified Files
--------------
src/backend/access/brin/brin_tuple.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix up pg_dump's handling of per-attribute compression options.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Move lwlock-release probe back where it belongs