pgsql: Fix portability issue in new jsonbsubs code. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix portability issue in new jsonbsubs code.
Date
Msg-id E1l6TFj-0005CC-IN@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix portability issue in new jsonbsubs code.  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-committers
Fix portability issue in new jsonbsubs code.

On machines where sizeof(Datum) > sizeof(Oid) (that is, any 64-bit
platform), the previous coding would compute a misaligned
workspace->index pointer if nupper is odd.  Architectures where
misaligned access is a hard no-no would then fail.  This appears
to explain why thorntail is unhappy but other buildfarm members
are not.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7c5d57caed4d8af705d0cc3131d0d8ed72b7a41d

Modified Files
--------------
src/backend/utils/adt/jsonbsubs.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Implementation of subscripting for jsonb
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Implementation of subscripting for jsonb