pgsql: Fix pull_varnos' miscomputation of relids set for a PlaceHolderV - Mailing list pgsql-committers

Fix pull_varnos' miscomputation of relids set for a PlaceHolderVar.

Previously, pull_varnos() took the relids of a PlaceHolderVar as being
equal to the relids in its contents, but that fails to account for the
possibility that we have to postpone evaluation of the PHV due to outer
joins.  This could result in a malformed plan.  The known cases end up
triggering the "failed to assign all NestLoopParams to plan nodes"
sanity check in createplan.c, but other symptoms may be possible.

The right value to use is the join level we actually intend to evaluate
the PHV at.  We can get that from the ph_eval_at field of the associated
PlaceHolderInfo.  However, there are some places that call pull_varnos()
before the PlaceHolderInfos have been created; in that case, fall back
to the conservative assumption that the PHV will be evaluated at its
syntactic level.  (In principle this might result in missing some legal
optimization, but I'm not aware of any cases where it's an issue in
practice.)  Things are also a bit ticklish for calls occurring during
deconstruct_jointree(), but AFAICS the ph_eval_at fields should have
reached their final values by the time we need them.

The main problem in making this work is that pull_varnos() has no
way to get at the PlaceHolderInfos.  We can fix that easily, if a
bit tediously, in HEAD by passing it the planner "root" pointer.
In the back branches that'd cause an unacceptable API/ABI break for
extensions, so leave the existing entry points alone and add new ones
with the additional parameter.  (If an old entry point is called and
encounters a PHV, it'll fall back to using the syntactic level,
again possibly missing some valid optimization.)

Back-patch to v12.  The computation is surely also wrong before that,
but it appears that we cannot reach a bad plan thanks to join order
restrictions imposed on the subquery that the PlaceHolderVar came from.
The error only became reachable when commit 4be058fe9 allowed trivial
subqueries to be collapsed out completely, eliminating their join order
restrictions.

Per report from Stephan Springl.

Discussion: https://postgr.es/m/171041.1610849523@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55dc86eca70b1dc18a79c141b3567efed910329d

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c       |  3 +-
src/backend/optimizer/path/clausesel.c    | 12 +++---
src/backend/optimizer/path/costsize.c     |  2 +-
src/backend/optimizer/path/equivclass.c   | 17 +++++---
src/backend/optimizer/path/indxpath.c     | 61 ++++++++++++++++-----------
src/backend/optimizer/path/pathkeys.c     |  2 +-
src/backend/optimizer/path/tidpath.c      | 18 ++++----
src/backend/optimizer/plan/analyzejoins.c |  2 +-
src/backend/optimizer/plan/initsplan.c    | 31 ++++++++------
src/backend/optimizer/plan/subselect.c    |  4 +-
src/backend/optimizer/prep/prepjointree.c | 40 +++++++++++-------
src/backend/optimizer/util/clauses.c      |  4 +-
src/backend/optimizer/util/inherit.c      |  5 ++-
src/backend/optimizer/util/orclauses.c    |  3 +-
src/backend/optimizer/util/placeholder.c  |  2 +-
src/backend/optimizer/util/restrictinfo.c | 39 ++++++++++-------
src/backend/optimizer/util/var.c          | 69 +++++++++++++++++++++----------
src/backend/utils/adt/selfuncs.c          |  4 +-
src/include/optimizer/clauses.h           |  2 +-
src/include/optimizer/optimizer.h         |  7 ++--
src/include/optimizer/paths.h             |  3 +-
src/include/optimizer/planmain.h          |  3 +-
src/include/optimizer/restrictinfo.h      |  7 ++--
src/test/regress/expected/join.out        | 36 ++++++++++++++++
src/test/regress/sql/join.sql             | 16 +++++++
25 files changed, 261 insertions(+), 131 deletions(-)