pgsql: Fix memory leak in SnapBuildSerialize. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix memory leak in SnapBuildSerialize.
Date
Msg-id E1kzXba-0002D8-3B@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix memory leak in SnapBuildSerialize.

The memory for the snapshot was leaked while serializing it to disk during
logical decoding. This memory will be freed only once walsender stops
streaming the changes. This can lead to a huge memory increase when master
logs Standby Snapshot too frequently say when the user is trying to create
many replication slots.

Reported-by: funnyxj.fxj@alibaba-inc.com
Diagnosed-by: funnyxj.fxj@alibaba-inc.com
Author: Amit Kapila
Backpatch-through: 9.5
Discussion: https://postgr.es/m/033ab54c-6393-42ee-8ec9-2b399b5d8cde.funnyxj.fxj@alibaba-inc.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7adc408f4b64db1c9244dc48d40b87ba8be9df9a

Modified Files
--------------
src/backend/replication/logical/snapbuild.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Optimize DropRelFileNodesAllBuffers() for recovery.
Next
From: Thomas Munro
Date:
Subject: pgsql: Don't use elog() in src/port/pwrite.c.