pgsql: Fix bug #16784 in Disk-based Hash Aggregation. - Mailing list pgsql-committers

From Jeff Davis
Subject pgsql: Fix bug #16784 in Disk-based Hash Aggregation.
Date
Msg-id E1ktLFN-0008Vb-Ut@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bug #16784 in Disk-based Hash Aggregation.

Before processing tuples, agg_refill_hash_table() was setting all
pergroup pointers to NULL to signal to advance_aggregates() that it
should not attempt to advance groups that had spilled.

The problem was that it also set the pergroups for sorted grouping
sets to NULL, which caused rescanning to fail.

Instead, change agg_refill_hash_table() to only set the pergroups for
hashed grouping sets to NULL; and when compiling the expression, pass
doSort=false.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/16784-7ff169bf2c3d1588%40postgresql.org
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7b8692eaf113a56933c77cf4c3993716ab37e763

Modified Files
--------------
src/backend/executor/nodeAgg.c             |  24 +++-
src/test/regress/expected/groupingsets.out | 207 +++++++++++++++++++++++++++++
src/test/regress/sql/groupingsets.sql      |  21 +++
3 files changed, 245 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Fix bug #16784 in Disk-based Hash Aggregation.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix bug #16784 in Disk-based Hash Aggregation.