pgsql: jit: Correct parameter type for generated expression evaluation - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: jit: Correct parameter type for generated expression evaluation
Date
Msg-id E1kmTly-0004a5-SK@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
jit: Correct parameter type for generated expression evaluation functions.

clang only uses the 'i1' type for scalar booleans, not for pointers to
booleans (as the pointer might be pointing into a larger memory
allocation). Therefore a pointer-to-bool needs to the "storage" boolean.

There's no known case of wrong code generation due to this, but it seems quite
possible that it could cause problems (see e.g. 72559438f92).

Author: Andres Freund
Discussion: https://postgr.es/m/20201207212142.wz5tnbk2jsaqzogb@alap3.anarazel.de
Backpatch: 11-, where jit support was added

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5da871bfa1ba41768ecd7786293d9b81dcf1b667

Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: backpatch "jit: Add support for LLVM 12."
Next
From: Michael Paquier
Date:
Subject: pgsql: pgcrypto: Detect errors with EVP calls from OpenSSL