pgsql: Fix miscomputation of direct_lateral_relids for join relations. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix miscomputation of direct_lateral_relids for join relations.
Date
Msg-id E1kjmtS-0003rC-CZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix miscomputation of direct_lateral_relids for join relations.

If a PlaceHolderVar is to be evaluated at a join relation, but
its value is only needed there and not at higher levels, we neglected
to update the joinrel's direct_lateral_relids to include the PHV's
source rel.  This causes problems because join_is_legal() then won't
allow joining the joinrel to the PHV's source rel at all, leading
to "failed to build any N-way joins" planner failures.

Per report from Andreas Seltenreich.  Back-patch to 9.5
where the problem originated.

Discussion: https://postgr.es/m/87blfgqa4t.fsf@aurora.ydns.eu

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b1738ff6ab73203cbbc02d7fb82941dbc061d301

Modified Files
--------------
src/backend/optimizer/util/placeholder.c | 38 +++++++++++++------
src/test/regress/expected/join.out       | 64 ++++++++++++++++++++++++++++++++
src/test/regress/sql/join.sql            | 27 ++++++++++++++
3 files changed, 118 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Refactor parsing rules for option lists of EXPLAIN, VACUUM and A
Next
From: Tom Lane
Date:
Subject: pgsql: Prevent parallel index build in a standalone backend.