pgsql: Remove ineffective heapam CHECK_FOR_INTERRUPTS(). - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Remove ineffective heapam CHECK_FOR_INTERRUPTS().
Date
Msg-id E1kcAXP-00040O-Ra@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove ineffective heapam CHECK_FOR_INTERRUPTS().

Remove a CHECK_FOR_INTERRUPTS() call that could never actually handle an
interrupt.  We always have a heap page buffer lock at this point.
Having a useless CHECK_FOR_INTERRUPTS() call is harmless but misleading.

It is probably possible to work around the immediate problem by moving
the CHECK_FOR_INTERRUPTS() to before the heap page buffer lock is
acquired.  That isn't enough to make the function responsive to
interrupts, though.  The index AM caller will still hold an exclusive
buffer lock of its own.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/180cf876d457c260291af070d883c5db5033cb3a

Modified Files
--------------
src/backend/access/heap/heapam.c | 1 -
1 file changed, 1 deletion(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: In security-restricted operations, block enqueue of at-commit us
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: clarify data type behavior of COALESCE and NULLIF.